Return static from fluid setters #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
return-static
branch
from
30789e4
to
7d2da2c
Compare
|
Looks like a bunch of generated code is being updated. PR only the non-generated code changes and let the cron pickup the generated ones? |
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
return-static
branch
from
8c3b0f4
to
02b4295
Compare
|
Done ✔️ |
shyim
previously approved these changes
Nov 5, 2024
Signed-off-by: Shyim <[email protected]>
shyim
approved these changes
Nov 5, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #233 we are proposing to provide an interface for common fluid setters, how the specific return type that is generated for the fluid setters prevents this.
PHP 8.0 introduced
staticas a return type to solve this problem by using late static binding. See https://wiki.php.net/rfc/static_return_typeIssues Resolved
Allows re-use of common fluid setters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.